runtime-config-linux: Add info to clarify oom_score_adj (carrying #236) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChengTiesheng <chengtiesheng@huawei.com>
| @@ -180,7 +180,13 @@ For more information, see [the memory cgroup man page](https://www.kernel.org/do | |||
|
|
|||
| #### Set oom_score_adj | |||
|
|
|||
| More information on `oom_score_adj` available [here](https://www.kernel.org/doc/Documentation/filesystems/proc.txt). | |||
| oom_score_adj works with disableOOMKiller. | |||
| If out-of-memory killer disabled("disableOOMKiller": true), the value of oom_score_adj is useless and will be omitted. | |||
vbatts
force-pushed
the
tiesheng_oomscoreadj
branch
from
c1f8953 to
1bfadf6
Compare
| @@ -180,7 +180,14 @@ For more information, see [the memory cgroup man page](https://www.kernel.org/do | |||
|
|
|||
| #### Set oom_score_adj | |||
|
|
|||
| More information on `oom_score_adj` available [here](https://www.kernel.org/doc/Documentation/filesystems/proc.txt). | |||
| oom_score_adj sets heuristic regarding how the process is evaluated by the kernel during memory pressure. | |||
There was a problem hiding this comment.
“oom_score_adj” should probaby be “oom_score_adj” or “oom_score_adj”. And maybe reword to:
oom_score_adjadjusts the kernel's process evaluation during memory pressure.
There was a problem hiding this comment.
On Tue, Jan 05, 2016 at 12:47:42PM -0800, Vincent Batts wrote:
but it is per process
Right. I just think “sets heuristic regarding how the process is
evaluated by the kernel” could be condensed without losing
information. How about something closer to the kernel's §3.1 lead in
1:
oom_score_adj adjusts the OOM-killer badness heuristic for this
process.
?
vbatts
force-pushed
the
tiesheng_oomscoreadj
branch
from
1bfadf6 to
59e92d2
Compare
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
force-pushed
the
tiesheng_oomscoreadj
branch
from
59e92d2 to
011acdf
Compare
|
LGTM |
|
lgtm |
|
LGTM |
vishh
added a commit
that referenced
this pull request
Jan 6, 2016
runtime-config-linux: Add info to clarify oom_score_adj (carrying #236)
Merged
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 9, 2017
The only discussion related to this is in [1,2], where the relationship between oomScoreAdj and disableOOMKiller is raised. But since 429f936 (Adding cgroups path to the Spec, 2015-09-02, opencontainers#137) resources has been tied to cgroups, and oomScoreAdj is not about cgroups. For example, we currently have (in config-linux.md): You can configure a container's cgroups via the resources field of the Linux configuration. I suggested we move the property from linux.resources.oomScoreAdj to linux.oomScoreAdj so config authors and runtimes don't have to worry about what cgroupsPath means if the only entry in resources is oomScoreAdj. Michael responded with [4]: If anything it should probably go on the process So that's what this commit does. [1]: opencontainers#236 [2]: opencontainers#292 [3]: opencontainers#137 [4]: opencontainers#782 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 9, 2017
The only discussion related to this is in [1,2], where the relationship between oomScoreAdj and disableOOMKiller is raised. But since 429f936 (Adding cgroups path to the Spec, 2015-09-02, opencontainers#137) resources has been tied to cgroups, and oomScoreAdj is not about cgroups. For example, we currently have (in config-linux.md): You can configure a container's cgroups via the resources field of the Linux configuration. I suggested we move the property from linux.resources.oomScoreAdj to linux.oomScoreAdj so config authors and runtimes don't have to worry about what cgroupsPath means if the only entry in resources is oomScoreAdj. Michael responded with [4]: If anything it should probably go on the process So that's what this commit does. I've gone with the four-space indents here to keep Pandoc happy (see 7795661 (runtime.md: Fix sub-bullet indentation, 2016-06-08, opencontainers#495), but have left the existing entries in this list unchanged to reduce churn. [1]: opencontainers#236 [2]: opencontainers#292 [3]: opencontainers#137 [4]: opencontainers#782 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
May 9, 2017
The only discussion related to this is in [1,2], where the relationship between oomScoreAdj and disableOOMKiller is raised. But since 429f936 (Adding cgroups path to the Spec, 2015-09-02, opencontainers#137) resources has been tied to cgroups, and oomScoreAdj is not about cgroups. For example, we currently have (in config-linux.md): You can configure a container's cgroups via the resources field of the Linux configuration. I suggested we move the property from linux.resources.oomScoreAdj to linux.oomScoreAdj so config authors and runtimes don't have to worry about what cgroupsPath means if the only entry in resources is oomScoreAdj. Michael responded with [4]: If anything it should probably go on the process So that's what this commit does. I've gone with the four-space indents here to keep Pandoc happy (see 7795661 (runtime.md: Fix sub-bullet indentation, 2016-06-08, opencontainers#495), but have left the existing entries in this list unchanged to reduce churn. [1]: opencontainers#236 [2]: opencontainers#292 [3]: opencontainers#137 [4]: opencontainers#782 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is carrying #236, but deferring the description to the linux docs.